[BUG FIX] Preserve model context across agent handoffs and background tasks #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #191 This commit addresses three critical issues with model selection: 1. **Background Agent Manager Model Preservation** - Updated BackgroundTask and LaunchInput types to include parentModel field - Modified manager.ts to capture and store parent model context - Updated notifyParentSession() to pass model field when resuming parent session - Background tasks now preserve the user's selected model across continuations 2. **Librarian Agent Factory Pattern** - Converted librarian agent from static config to factory function - Added createLibrarianAgent(model?: string) with configurable model parameter - Maintained backward compatibility with exported librarianAgent constant - Updated utils.ts to use the new factory function 3. **Background Task Tool Model Context Capture** - Updated background_task tool to capture current model context - Uses findNearestMessageWithFields() to get model info from parent session - Passes parentModel to manager.launch() for proper context preservation Changes: - src/features/background-agent/types.ts: Add parentModel field to BackgroundTask and LaunchInput - src/features/background-agent/manager.ts: Store and preserve parent model context - src/agents/librarian.ts: Convert to factory pattern with configurable model - src/agents/utils.ts: Use createLibrarianAgent factory - src/tools/background-task/tools.ts: Capture and pass model context - assets/oh-my-opencode.schema.json: Regenerated schema Impact: - Users with OAuth providers (Google, Anthropic) will now have their model selection preserved - Background agents no longer revert to hardcoded defaults - Agent model configuration is now more flexible and user-controllable Testing: - All existing tests pass (20/20) - Build succeeds with no errors - Backward compatibility maintained
Owner
|
@sisyphus-dev-ai hey pull rebase and resolve conflicts push bro |
sisyphus-dev-ai
added
the
sisyphus: working
Collaborator
Author
|
👋 Hey @code-yeongyu! I'm on it... |
sisyphus-dev-ai
removed
the
sisyphus: working
Owner
|
@sisyphus-dev-ai hello? you must resolve ulw |
sisyphus-dev-ai
added
the
sisyphus: working
Collaborator
Author
|
👋 Hey @code-yeongyu! I'm on it... |
sisyphus-dev-ai
removed
the
sisyphus: working
Owner
|
@sisyphus-dev-ai hey. said you to work. |
sisyphus-dev-ai
added
the
sisyphus: working
Collaborator
Author
|
👋 Hey @code-yeongyu! I'm on it... |
sisyphus-dev-ai
removed
the
sisyphus: working
Owner
|
@sisyphus-dev-ai hey, please resolve conflicts |
sisyphus-dev-ai
added
the
sisyphus: working
Collaborator
Author
|
👋 Hey @code-yeongyu! I'm on it... |
Collaborator
Author
|
✅ Conflicts resolved! I've created PR #229 with the resolved conflicts: #229 What was resolved:
All agents now use consistent factory pattern! 🎉 Verification:
The resolution preserves your PR's goals (model context preservation) while incorporating dev's parallel improvements (factory pattern for other agents). |
sisyphus-dev-ai
removed
the
sisyphus: working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #191 - Resolves model selection reverting to hardcoded Anthropic models instead of preserving user's OAuth/configured model across agent handoffs and background task continuations.
Changes
1. Background Agent Manager Model Preservation
src/features/background-agent/types.ts: AddedparentModelfield toBackgroundTaskandLaunchInputinterfacessrc/features/background-agent/manager.ts:parentModelwith fallback tofindNearestMessageWithFields()for resilience2. Librarian Agent Factory Pattern
src/agents/librarian.ts:createLibrarianAgent(model?: string)DEFAULT_MODELconstantlibrarianAgentconstantsrc/agents/utils.ts: Uses newcreateLibrarianAgentfactory3. Background Task Tool Model Context Capture
src/tools/background-task/tools.ts:findNearestMessageWithFields()parentModeltomanager.launch()for proper context preservationImpact
✅ Fixes
🔧 Technical Improvements
🛡️ Backward Compatibility
Testing
Files Changed
src/features/background-agent/types.ts- Add model context fieldssrc/features/background-agent/manager.ts- Preserve and pass model contextsrc/agents/librarian.ts- Convert to factory with configurable modelsrc/agents/utils.ts- Use librarian factorysrc/tools/background-task/tools.ts- Capture and pass model contextassets/oh-my-opencode.schema.json- Regenerated JSON schemaRelated Issues
Closes #191
Additional Notes
This is a targeted fix addressing the core issue without over-engineering. The solution:
Future work could include making all agents use factory patterns and adding global model persistence configuration options, but this PR focuses on fixing the immediate bug.